This repository was archived by the owner on Apr 23, 2018. It is now read-only.
Add XHR error handling for offline #60
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is if the browser becomes offline and the XHR requests begin to error, my JS app continues to run and watch for online availability.
This adds a hook to push
nullinto the latency array if the XHR request responded with the error event, allowing thenet.latency.on( 'end' )callback to receivenullinformation and conclude there is no connection. Not sure if these needs to accommodate for intentional server errors, but it's an improvement in my case.